Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused osbuilder flags #200

Merged
merged 1 commit into from
May 22, 2024
Merged

Remove unused osbuilder flags #200

merged 1 commit into from
May 22, 2024

Conversation

mauromorales
Copy link
Member

@mauromorales mauromorales requested a review from a team May 22, 2024 13:22
@mauromorales mauromorales self-assigned this May 22, 2024
@netlify Netlify
Copy link

netlify bot commented May 22, 2024 •
edited
Loading

✅ Deploy Preview for kairos-io ready!

Name Link
🔨 Latest commit 4d892ab
🔍 Latest deploy log https://app.netlify.com/sites/kairos-io/deploys/664df1ae3bfe8900087374ca
😎 Deploy Preview https://deploy-preview-200--kairos-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Itxaka
Itxaka approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@Itxaka Itxaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to check the OCI vs docker part? Like the transport will tackle OCI as remote and docker as local IIRC? Or I'm remembering it wrong?

@mauromorales
Copy link
Member Author

@Itxaka good question, I'm not sure about that but regardless of, the local flag doesn't do anything

@mauromorales mauromorales merged commit 1b6db82 into main May 22, 2024
5 checks passed
@mauromorales mauromorales deleted the 2212-local-flag branch May 22, 2024 14:53
@mauromorales
Copy link
Member Author

@Itxaka ah I'm silly this is the docs so you mean to inform the user, my bad sorry. I will test and follow up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Itxaka Itxaka Itxaka approved these changes

Assignees

@mauromorales mauromorales

Labels
None yet
Projects
🧙Issue tracking board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enki: the --local flag is missing
2 participants
@mauromorales @Itxaka