Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗️ Central http server where to push result artifacts #515

Closed
4 of 5 tasks
Tracked by #116
mudler opened this issue Nov 30, 2022 · 5 comments · Fixed by kairos-io/osbuilder#22
Closed
4 of 5 tasks
Tracked by #116

🏗️ Central http server where to push result artifacts #515

mudler opened this issue Nov 30, 2022 · 5 comments · Fixed by kairos-io/osbuilder#22
Assignees
Labels
area/osbuilder enhancement New feature or request size: 8 2 or 3 days are required for this card

Comments

@mudler
Copy link
Member

mudler commented Nov 30, 2022

Instead of spawning up servers for all every artifact, we should have a single server that binds to a pvc that can be set, and makes artifacts available. Bonus points if this can be configured somehow (can I provide my own server?)

  • osbuilder should create jobs that push to a PVC rather then create a full server
  • osbuilder should cleanup with finalizers when the osartifact is removed
  • chart, if setting up a server, should expose services/ingress configuration for exposing it
  • pushing results to the pod via kubernetes rest-api, re-use existing http server that could be also provided by the user (label to identify pod, path where to push where pvc is mounted)
  • QA tests
@mudler mudler added area/osbuilder enhancement New feature or request labels Nov 30, 2022
@mudler mudler moved this to Todo 🖊 in 🧙Issue tracking board Nov 30, 2022
@mudler mudler added the size: 8 2 or 3 days are required for this card label Nov 30, 2022
@mudler mudler changed the title osbuilder: Central http server where to push result artifacts 🏗️ Central http server where to push result artifacts Nov 30, 2022
@jimmykarily jimmykarily moved this from Todo 🖊 to In Progress 🏃 in 🧙Issue tracking board Dec 2, 2022
@jimmykarily jimmykarily self-assigned this Dec 2, 2022
@jimmykarily
Copy link
Contributor

Started a refactoring here: https://github.com/spectrocloud/kubesplit/tree/remove-dependencies
We need to be able to produce helm charts easily for fast iterations so we can't afford manual helm chart editing.

The libraries we used in kubesplit had some limitations (e.g. they couldn't replace maps with a string value, which is what you do when you create a helm template). E.g.

	Replacement: replaceKeyValue(`/spec/template/metadata/labels`, `{{- include "helm-chart.selectorLabels" . | nindent 10 }}`),

and we figured out it's possible with with our jq unstructured library from kairos repo.
Also those libraries are no longer maintained so we couldn't expect any new features.

@jimmykarily
Copy link
Contributor

jimmykarily commented Dec 2, 2022

@jimmykarily
Copy link
Contributor

osbuilder work happening here: https://github.com/kairos-io/osbuilder/tree/515-central-server

@jimmykarily
Copy link
Contributor

@jimmykarily jimmykarily moved this from In Progress 🏃 to Under review 🔍 in 🧙Issue tracking board Dec 15, 2022
Repository owner moved this from Under review 🔍 to Done ✅ in 🧙Issue tracking board Dec 15, 2022
@jimmykarily
Copy link
Contributor

Docs: #566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/osbuilder enhancement New feature or request size: 8 2 or 3 days are required for this card
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants