-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add permanent nginx server and consume newer osbuilder #6
Conversation
so that artifacts can be written to the permanent server Signed-off-by: Dimitris Karakasilis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! just few nits, I think we are fine just opening follow-ups and merge this as is
@jimmykarily do we need to tag the image before merging? |
I think we need to generate the new osbuilder image somehow. I guess it's a pipeline in the osbuilder repository, probably run after tagging it or such. |
Done, and released: https://github.com/kairos-io/helm-charts/releases/tag/osbuilder-0.5.1 |
so that artifacts can be written to the permanent server
Part of: kairos-io/kairos#515
Signed-off-by: Dimitris Karakasilis [email protected]