Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permanent nginx server and consume newer osbuilder #6

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

jimmykarily
Copy link
Contributor

so that artifacts can be written to the permanent server

Part of: kairos-io/kairos#515

Signed-off-by: Dimitris Karakasilis [email protected]

so that artifacts can be written to the permanent server

Signed-off-by: Dimitris Karakasilis <[email protected]>
Copy link
Member

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! just few nits, I think we are fine just opening follow-ups and merge this as is

@mudler
Copy link
Member

mudler commented Dec 16, 2022

@jimmykarily do we need to tag the image before merging?

@jimmykarily
Copy link
Contributor Author

@jimmykarily do we need to tag the image before merging?

I think we need to generate the new osbuilder image somehow. I guess it's a pipeline in the osbuilder repository, probably run after tagging it or such.

@jimmykarily jimmykarily merged commit 42cb487 into main Dec 19, 2022
@jimmykarily jimmykarily deleted the 515-central-server branch December 19, 2022 10:08
@jimmykarily
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants