✨ Set rpi images with lvm by default

[Itxaka]

What this PR does / why we need it:

Enables LVM by default on RPI images, which means that the recovery partition will be an lvm partition

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1271

[netlify]

✅ Deploy Preview for kairos-io canceled.

Name	Link
🔨 Latest commit	45f7f86
🔍 Latest deploy log	https://app.netlify.com/sites/kairos-io/deploys/6447ac1dd9975d0008e6812a

[codecov-commenter]

Codecov Report

Merging #1353 (45f7f86) into master (7bb9af9) will increase coverage by 3.13%.
The diff coverage is 51.05%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1353      +/-   ##
==========================================
+ Coverage   22.79%   25.92%   +3.13%     
==========================================
  Files          22       17       -5     
  Lines        1610     1427     -183     
==========================================
+ Hits          367      370       +3     
+ Misses       1179      997     -182     
+ Partials       64       60       -4     

Impacted Files	Coverage Δ
internal/agent/config.go	0.00% <ø> (ø)
internal/agent/interactive_install.go	0.00% <ø> (ø)
internal/agent/notify.go	0.00% <0.00%> (ø)
internal/agent/recovery.go	0.00% <ø> (ø)
internal/agent/reset.go	0.00% <0.00%> (ø)
internal/agent/upgrade.go	0.00% <0.00%> (ø)
pkg/config/config.go	0.00% <0.00%> (-51.36%)	⬇️
internal/agent/install.go	5.10% <21.21%> (+5.10%)	⬆️
pkg/config/collector/options.go	64.51% <37.50%> (ø)
pkg/config/collector/collector.go	66.55% <66.55%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[mauromorales]

Seems to boot correctly

but when trying to install I get the following error

Does my way to try to install here make any sense? Probably not and I need to build the image with the config I want already in

[Itxaka]

Seems to boot correctly but when trying to install I get the following error

nice!

Can you try with a normal image as well? Maybe its still broken :D
v2.0.3 should be ready soon

[Itxaka]

Does my way to try to install here make any sense? Probably not and I need to build the image with the config I want already in

umm good point, rpi images are not installed, they are just dumped into the SD as they are raw images. Of course you are not gonna be able to install LOL

Almost got me there for a second @mauromorales ;)

RAW images are just installed systems ready to flash to a card. installation means nothing in there, only upgrade and Im guessing reset...upgrade I tested and it went correctly but reset + upgrade recovery could be tricky.

[mauromorales]

😅 sorry for the brain fart hehe

Maybe we should make the agent aware of this? Like don't offer to install if not possible, or give a message instead of an error?

[mauromorales]

LGTM

[Itxaka]

fails on leap+alpine :o

[mauromorales]

how come it works well on Tumbleweed but not leap 🧐

[Itxaka]

looks like the issue is that one of the parts is in use and it cant delete it:

           +arm-image *failed* | + kpartx -dv /dev/loop3
          +arm-image *failed* | del devmap : loop3p1
          +arm-image *failed* | del devmap : loop3p2
          +arm-image *failed* | loop3p3 is in use. Not removing

I dint get why, that part is not used....only loop3p1 is mounted??

[Itxaka]

for the life of me, I cant get this to happen locally, so Im guessing its a timing issue?

[mauromorales]

its green 🟢 yeiii ... great work @Itxaka 💪

[Itxaka]

its green green_circle yeiii ... great work @Itxaka muscle

welp, I wanted to try them manually, now that I got my rpi up and running with usb+serial :D