Fully drop elemental from kairos #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Itxaka
force-pushed
the
v2
branch
2 times, most recently
from
9d67b13 to
9344731
Compare
Itxaka
force-pushed
the
v2
branch
11 times, most recently
from
905cd54 to
f4bb840
Compare
includes: - remove machine-id fully on openrc systems - fix alpine services sharing the same pid for kairos and webui - convert kairos openrc service into a one shot, as its not a daemon - bump peg - enable more debugging for tests, including getting the serial on failure - enable immucore.debug on tests - smaller fixes for yip files Signed-off-by: Itxaka <[email protected]>
Itxaka
commented
May 25, 2023
| start() { | ||
| kairos-agent start | ||
| eend $? |
There was a problem hiding this comment.
not a type, I assure you :D
Itxaka
commented
May 25, 2023
| @@ -5,24 +5,27 @@ stages: | |||
| if: '[ ! -f /oem/userdata ]' | |||
| name: "Pull data from provider" | |||
| datasource: | |||
| providers: ["cdrom", "gcp", "openstack", "aws", "azure", "hetzner", "packet", "scaleway", "vultr", "digitalocean", "metaldata"] | |||
| providers: ["cdrom", "gcp", "openstack", "aws", "azure", "hetzner", "packet", "vultr", "digitalocean", "metaldata"] | |||
There was a problem hiding this comment.
scaleway has no timeout out of the box so it can take up to 60 seconds to timeout if there is network during initramfs. Patch upstream to fix this has been sent and merged, waiting for it to trickle down.
Itxaka
commented
May 25, 2023
| files: | ||
| - path: /run/.userdata_load | ||
| initramfs.before: | ||
| - <<: *datasource | ||
| - if: '[ ! -f /oem/userdata ]' | ||
| files: | ||
| - path: /oem/.userdata_load | ||
| - path: /run/.userdata_load |
There was a problem hiding this comment.
leftover was breaking alpine
Itxaka
commented
May 25, 2023
| @@ -1,11 +1,11 @@ | |||
| name: "Start agent" | |||
| stages: | |||
| boot: | |||
| - if: '[ ! -f "/run/cos/recovery_mode" ]' | |||
| - if: '[ ! -f "/run/cos/recovery_mode" ] && [ -d "/usr/share/systemd" ]' | |||
There was a problem hiding this comment.
avoid running it on openrc systems. We need a better way to check this, probably via the kairos-agent state get init or something similar
Itxaka
commented
May 25, 2023
| @@ -33,6 +33,7 @@ stages: | |||
| /var/lib/wicked | |||
| /var/lib/longhorn | |||
| /var/lib/cni | |||
| /var/lib/dbus | |||
There was a problem hiding this comment.
alpine stores the machine-id here so it needs to be persistent
| @@ -2,6 +2,7 @@ ARG BASE_IMAGE=opensuse/tumbleweed | |||
|
|
|||
| FROM $BASE_IMAGE | |||
|
|
|||
| RUN zypper removerepo repo-openh264 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #