Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Directly blacklist the vc4 module everywhere #1443

Merged
merged 1 commit into from
May 25, 2023

Conversation

Itxaka
Copy link
Member

@Itxaka Itxaka commented May 23, 2023

This makes us drop the especific config files for rpi

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1407

This makes us drop the especific config files for rpi

Signed-off-by: Itxaka <[email protected]>
@Itxaka Itxaka requested review from mauromorales and a team May 23, 2023 13:19
@Itxaka
Copy link
Member Author

Itxaka commented May 23, 2023

cant build images locally, the script fails :/

Copy link
Member

@mauromorales mauromorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mauromorales
Copy link
Member

@Itxaka what issue do you get? seems to finish on my side, will copy to SD and test

@Itxaka
Copy link
Member Author

Itxaka commented May 23, 2023

@Itxaka what issue do you get? seems to finish on my side, will copy to SD and test

the losetup and the vg stuff seems to fail in my system and leaves around lv groups and loop devices mounted ¬_¬

@mauromorales
Copy link
Member

ah yes, that happens all the time, just get rid of them every time before running the build

$ sudo dmsetup remove <device_name>

@Itxaka
Copy link
Member Author

Itxaka commented May 23, 2023

ah yes, that happens all the time, just get rid of them every time before running the build

$ sudo dmsetup remove <device_name>

did several times... still fails

even with a clean system. Looks like my system doesnt like something that the script is doing...

@mauromorales
Copy link
Member

strange, worked well for me with ubuntu and opensuse

@jimmykarily
Copy link
Contributor

ah yes, that happens all the time, just get rid of them every time before running the build

$ sudo dmsetup remove <device_name>

did several times... still fails

even with a clean system. Looks like my system doesnt like something that the script is doing...

I have issues like that too. I do things like this (among other things) to make it work:

sudo dmsetup remove $(lsblk | grep -o -E 'loop.p.')

@Itxaka Itxaka enabled auto-merge (squash) May 23, 2023 20:07
@Itxaka Itxaka merged commit ffd9f67 into kairos-io:master May 25, 2023
Itxaka added a commit that referenced this pull request Jun 1, 2023
Itxaka added a commit that referenced this pull request Jun 1, 2023
Revert ":sparkles: Directly blacklist the vc4 module everywhere (#1443)"

This reverts commit ffd9f67.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Blacklist vc4 module for rpi
3 participants