-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🤖 test sysextension on uki #2617
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f5b7d16
to
f7f2b84
Compare
Signed-off-by: Itxaka <[email protected]>
jimmykarily
reviewed
Jun 17, 2024
jimmykarily
reviewed
Jun 17, 2024
jimmykarily
reviewed
Jun 17, 2024
jimmykarily
reviewed
Jun 17, 2024
jimmykarily
reviewed
Jun 17, 2024
|
||
By("Checking sysext was not copied during boot", func() { | ||
out, err := vm.Sudo("stat /.extra/sysext") | ||
Expect(err).To(HaveOccurred(), out) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or match the error explicitly (to make sure we got the expected one): https://github.com/onsi/gomega/blob/0e69083804979327b6008a5c7aaab402cd589c5a/matchers/match_error_matcher_test.go#L71
jimmykarily
approved these changes
Jun 17, 2024
Co-authored-by: Dimitris Karakasilis <[email protected]> Signed-off-by: Itxaka <[email protected]>
Co-authored-by: Dimitris Karakasilis <[email protected]> Signed-off-by: Itxaka <[email protected]>
Co-authored-by: Dimitris Karakasilis <[email protected]> Signed-off-by: Itxaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Itxaka [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #