Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐧 Remove RUN commands that change /etc/network/interfaces #831

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

sdwilsh
Copy link
Contributor

@sdwilsh sdwilsh commented Feb 7, 2023

What this PR does / why we need it:
This file is not used by systemd-networkd, but these images enable systemd-networkd. This change removes the RUN commands since the file should be unused.

This was originally identified in #821.

This file is not used by `systemd-networkd`, but these images enable
`systemd-networkd`.  This change removes the `RUN` commands since the
file should be unused.

This was originally identified in kairos-io#821.

Signed-off-by: Shawn Wilsher <[email protected]>
@netlify
Copy link

netlify bot commented Feb 7, 2023

Deploy Preview for kairos-io canceled.

Name Link
🔨 Latest commit 3a06219
🔍 Latest deploy log https://app.netlify.com/sites/kairos-io/deploys/63e1e665da47ca0008552cb6

Copy link
Member

@mauromorales mauromorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! thanks!

@mudler mudler enabled auto-merge (squash) February 7, 2023 09:55
@mudler mudler disabled auto-merge February 7, 2023 12:42
@mudler mudler merged commit aa97ca1 into kairos-io:master Feb 7, 2023
@sdwilsh sdwilsh deleted the remove-network-interfaces-run branch February 7, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants