-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐧 Add systemd-timesyncd
to all images that use systemd
#840
Conversation
✅ Deploy Preview for kairos-io canceled.
|
The project has documentation about using `timesyncd`, but the reality is that not all images included it. This change adds `systemd-timesyncd` to all machines that also install `systemd`. Signed-off-by: Shawn Wilsher <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #840 +/- ##
=======================================
Coverage 19.29% 19.29%
=======================================
Files 18 18
Lines 1467 1467
=======================================
Hits 283 283
Misses 1135 1135
Partials 49 49 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, lgtm
I guess the big benefit of using chrony is that we would not have to maintain two packages/configs, so IMO it would make sense. @mudler do you have more context of why systemd-timesyncd was introduced? |
Thanks! that's a good catch!
That's actually the benefit of Note, I don't have big preference - our |
I'd say the big difference of |
What this PR does / why we need it:
The project has documentation about using
timesyncd
, but the reality is that not all images included it. This change addssystemd-timesyncd
to all machines that also installsystemd
.Originally discovered while working on #821, but fixing for all
systemd
-based images here. However,fedora
doesn't havesystemd-timesyncd
and tells people to usechrony
instead, so it might make sense to standardize aroundchrony
in the future.opensuse
also does not have the packages.