Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐧 Add systemd-timesyncd to all images that use systemd #840

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

sdwilsh
Copy link
Contributor

@sdwilsh sdwilsh commented Feb 8, 2023

What this PR does / why we need it:
The project has documentation about using timesyncd, but the reality is that not all images included it. This change adds systemd-timesyncd to all machines that also install systemd.

Originally discovered while working on #821, but fixing for all systemd-based images here. However, fedora doesn't have systemd-timesyncd and tells people to use chrony instead, so it might make sense to standardize around chrony in the future. opensuse also does not have the packages.

@netlify
Copy link

netlify bot commented Feb 8, 2023

Deploy Preview for kairos-io canceled.

Name Link
🔨 Latest commit a23e500
🔍 Latest deploy log https://app.netlify.com/sites/kairos-io/deploys/63e31c02e38eb80008c2275b

The project has documentation about using `timesyncd`, but the reality
is that not all images included it.  This change adds
`systemd-timesyncd` to all machines that also install `systemd`.

Signed-off-by: Shawn Wilsher <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #840 (a23e500) into master (9e7a1ad) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #840   +/-   ##
=======================================
  Coverage   19.29%   19.29%           
=======================================
  Files          18       18           
  Lines        1467     1467           
=======================================
  Hits          283      283           
  Misses       1135     1135           
  Partials       49       49           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sdwilsh sdwilsh marked this pull request as ready for review February 8, 2023 04:38
Copy link
Member

@mauromorales mauromorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, lgtm

@mauromorales
Copy link
Member

I guess the big benefit of using chrony is that we would not have to maintain two packages/configs, so IMO it would make sense.

@mudler do you have more context of why systemd-timesyncd was introduced?

@mudler
Copy link
Member

mudler commented Feb 8, 2023

Thanks! that's a good catch!

I guess the big benefit of using chrony is that we would not have to maintain two packages/configs, so IMO it would make sense.

@mudler do you have more context of why systemd-timesyncd was introduced?

That's actually the benefit of systemd-timesyncd. Some distros ship that separately, some doesn't and it is just inside the same systemd package.

Note, systemd-timesyncd was introduced almost ~9 years ago: https://lists.freedesktop.org/archives/systemd-devel/2014-May/019537.html so I expect it to be present - if not, at some point it definetly should =).

I don't have big preference - our cloud config supports configuring it, however, it's not expected it to be present e.g. in distros that don't use systemd.

@mudler mudler merged commit 0f36f3a into kairos-io:master Feb 8, 2023
@sdwilsh
Copy link
Contributor Author

sdwilsh commented Feb 8, 2023

I'd say the big difference of systemd-timesyncd and chrony is that the former implements SNTP, but the later does full NTP. With chrony you could even setup your control plane to be the time servers for your nodes if you wanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants