Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐧 [ubuntu] Remove some packages that should not be needed #874

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

sdwilsh
Copy link
Contributor

@sdwilsh sdwilsh commented Feb 12, 2023

What this PR does / why we need it:
In #821 a number of packages were explicitly added that were previously installed automatically. This change removes some of the more obvious ones that we should not need to install manually.

In kairos-io#821 a number of packages were expliciatly added that were previously
installed automatically.  This change removes some of the more obvious
ones that we should not need to install manually.

Signed-off-by: Shawn Wilsher <[email protected]>
@netlify
Copy link

netlify bot commented Feb 12, 2023

Deploy Preview for kairos-io canceled.

Name Link
🔨 Latest commit 3261c93
🔍 Latest deploy log https://app.netlify.com/sites/kairos-io/deploys/63e87d568968a9000847a92b

@codecov-commenter
Copy link

Codecov Report

Merging #874 (3261c93) into master (3d839db) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #874   +/-   ##
=======================================
  Coverage   21.60%   21.60%           
=======================================
  Files          21       21           
  Lines        1523     1523           
=======================================
  Hits          329      329           
  Misses       1142     1142           
  Partials       52       52           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sdwilsh
Copy link
Contributor Author

sdwilsh commented Feb 12, 2023

Here's the delta's on size of packages installed

branch ubuntu ubuntu-22-lts ubuntu-20-lts
master 2061 MB 1855 MB 1739 MB
reduce-deps 1898 MB (-7.9%) 1699 MB (-8.4%) 1521 MB (-2.3%)

@sdwilsh sdwilsh marked this pull request as ready for review February 12, 2023 07:19
Copy link
Member

@mauromorales mauromorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants