Rework TPM workflow #318
Merged
Rework TPM workflow #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Itxaka
commented
May 21, 2024
•
Itxaka
commented
- Allows to pass tpm pcr and public key pcr banks to bind to
- Lots of more logging
- Separate luksify and luksify with measurements to make it clearer
- Drop the luks version, its not used anywhere and luks2 is safer
- log the actual command being run on debug
- enable debug mode for cryptenroll
- print debug content from cryptenroll on failure in order to make easier to troubleshoot
- As a side effect, it also avoids the print to stdout when adding a tpm key that it appears when used as a library
- even more logging
In order to expose more values especific to the tpm part Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Itxaka <[email protected]>
Itxaka
force-pushed
the
rework_measurements
branch
from
375dc66 to
3ebf55a
Compare
jimmykarily
approved these changes
May 23, 2024
Co-authored-by: Dimitris Karakasilis <[email protected]>
Co-authored-by: Dimitris Karakasilis <[email protected]>
mauromorales
approved these changes
May 23, 2024
|
Blocked until #328 gets in as that has higher priority over this due to need for backports |
Signed-off-by: Itxaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.