Remove tools image references and opt for auroraboot #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmykarily
force-pushed
the
1633-remove-tools-image
branch
from
5b35976 to
cbef773
Compare
because it has been merged with auroraboot here: kairos-io/AuroraBoot#110 as part of kairos-io/kairos#1633 Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
force-pushed
the
1633-remove-tools-image
branch
from
cbef773 to
d186dc7
Compare
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
commented
Nov 15, 2024
jimmykarily
commented
Nov 15, 2024
Itxaka
approved these changes
Nov 15, 2024
jimmykarily
added a commit
to kairos-io/AuroraBoot
that referenced
this pull request
Nov 15, 2024
When the user says "--output mydir" they really expect the artifacts to be in `mydir`, not in `mydir/build`. See also: - kairos-io/osbuilder#192 (comment) - kairos-io/kairos-docs#311 (comment) Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
added a commit
to kairos-io/AuroraBoot
that referenced
this pull request
Nov 15, 2024
When the user says "--output mydir" they really expect the artifacts to be in `mydir`, not in `mydir/build`. See also: - kairos-io/osbuilder#192 (comment) - kairos-io/kairos-docs#311 (comment) Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
added a commit
to kairos-io/AuroraBoot
that referenced
this pull request
Nov 15, 2024
When the user says "--output mydir" they really expect the artifacts to be in `mydir`, not in `mydir/build`. See also: - kairos-io/osbuilder#192 (comment) - kairos-io/kairos-docs#311 (comment) Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
added a commit
to kairos-io/AuroraBoot
that referenced
this pull request
Nov 15, 2024
When the user says "--output mydir" they really expect the artifacts to be in `mydir`, not in `mydir/build`. See also: - kairos-io/osbuilder#192 (comment) - kairos-io/kairos-docs#311 (comment) Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
added a commit
to kairos-io/AuroraBoot
that referenced
this pull request
Nov 15, 2024
When the user says "--output mydir" they really expect the artifacts to be in `mydir`, not in `mydir/build`. See also: - kairos-io/osbuilder#192 (comment) - kairos-io/kairos-docs#311 (comment) Signed-off-by: Dimitris Karakasilis <[email protected]>
because it has been fixed here: kairos-io/AuroraBoot#115 Signed-off-by: Dimitris Karakasilis <[email protected]>
There was a problem hiding this comment.
line 184:
"/raw-images.sh /rootfs /artifacts/%s.raw",
need to replace "/raw-images.sh" as the file was removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the tools image has been merged to the auroraboot one here: kairos-io/AuroraBoot#110
Part of kairos-io/kairos#1633
Fixes kairos-io/kairos#1634 and kairos-io/kairos#1635