Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CChar #126

Merged
merged 2 commits into from
Aug 12, 2020
Merged

Remove CChar #126

merged 2 commits into from
Aug 12, 2020

Conversation

jeehoonkang
Copy link
Member

  • c_char는 원래 string을 표현하는데 사용되었었는데, u8로 대체해도 될 것 같습니다.
  • 나중에는 u8로 string을 표현하는 것도 다 없애고 rust &str를 사용해야 합니다.

@jeehoonkang
Copy link
Member Author

한분이라도 approve 해주시면 머지하겠습니다.

Copy link
Collaborator

@coolofficials coolofficials left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

무의미한 type casting이 조금 보이는 것 같습니다.
이번에 해결하는 것이 좋을 것 같습니다.

  • 남은 CChar 없는 것 확인했습니다.
  • 현재 단계에서 u8과 관련된 무의미한 type casting 리뷰에 남긴 것 제외하고 없는 것 확인했습니다.

추가로 다른 이슈에서 CVoid 관련해서도 고민을 해봐야할 것 같습니다. (libc의 완벽한 제거와 무의미한 type casting의 제거를 위해)

review에 남긴 type casting들 제거해도 usertests all pass 하는 것 local에서 확인했습니다.

review 다 resolve 되면 merge 해도 될 것 같습니다.

kernel-rs/src/printf.rs Outdated Show resolved Hide resolved
kernel-rs/src/sysfile.rs Outdated Show resolved Hide resolved
kernel-rs/src/sysfile.rs Outdated Show resolved Hide resolved
kernel-rs/src/virtio_disk.rs Outdated Show resolved Hide resolved
kernel-rs/src/virtio_disk.rs Outdated Show resolved Hide resolved
kernel-rs/src/proc.rs Outdated Show resolved Hide resolved
kernel-rs/src/string.rs Outdated Show resolved Hide resolved
kernel-rs/src/string.rs Outdated Show resolved Hide resolved
kernel-rs/src/string.rs Outdated Show resolved Hide resolved
kernel-rs/src/virtio_disk.rs Outdated Show resolved Hide resolved
@jeehoonkang jeehoonkang merged commit ffa7c17 into kaist-cp:riscv Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants