Restructure + optimize codebase #58
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Part of bigger restructuring for dagster - Initialize application with name and location of installation. Updated nhp_dwiproc.app.utils.app + other sub-modules requiring APP_NAME as needed for these changes. - Optimize nhp_dwiproc.app.utils.app in the process - Remove unneeded type.py file - Moved library utilities to parent folder and renamed to assets to reflect the module they will interact with - Moved app utilities to parent folder and fixed imports - Moved io utilities to parent order, fixed imports, and initialized sub module as needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a restructuring of the codebase to simplify and reduce redundancy of sub-modules (e.g. 2
utilsin different submodules). As part of the the restructuring, optimization of the codebase is also performed to make it more easily maintainable. Changes include:
nhp_dwiprocpackage with name and location of installation.utilscalls requiringAPP_NAMEas neededutilstype.py; used to defineStrPathwhich was never used throughout the codebaselib.utils) tonhp_dwiproc.utils.assetsto reflect utilities for interacting with dagster assetsutils.io) tonhp_dwiproc.utils.ioStill to be tested prior for PR being ready for merge.