Support custom localisation and other yadda options #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At my work we're using fork of ember-cli-yadda everyday in cooperation with architects. There are already only 2 missing functionalities in this plugin which we need to use original plugin (BTW thanks for adding @ignore annotation, that is what we've also needed). I mean:
Our fork of ember-cli-yadda has hardcoded FeatureParser initialization, it looks like that:
We need also possibility to change square brackets into angle brackets for using variables due to cooperation also with PHP Team. They are using Behat, and there are angle brackets for using variables behat docs. We've decided to be consistent with PHP Team.
With this PR changes we will be able to set custom yadda config in our app environment config by adding:
So here is my PR which should resolve our problems and allows us to use official version of ember-cli-yadda. I'm open to any suggestions if it needs some improvements.
I wanted to write some tests, but it needs some tricky way to use custom acceptance tests directory. Because with custom configuration current tests will definetly fail (and thats correct, using another localisation, english tests can't work). I can add tests later in another PR (it really needs tricky way which i didn't want to include in this PR).
Note: this version of code is fully backward compatible.