Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two issues here how the
FeatureParser
generated imports, that somehow worked in a classic build, but broke in Embroider:yadda-annotations.js
was imported, though that doesn't even exist, it only has named exports. Probably the way ember-cli transpiles ES modules to AMD made this work accidentally!?tests/accpetance/steps/foo-steps.js
, which is neither an absolute path (there is notests
package) nor a relative. Changed to use relative paths (./steps/foo-steps.js
)Also adds additional test scenarios for Embroider, using their new test infrastructure.
This is based on top of #83, as it would have merge conflicts otherwise, so best review by commit.