Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Embroider #87

Merged
merged 2 commits into from
Nov 6, 2020
Merged

Support Embroider #87

merged 2 commits into from
Nov 6, 2020

Conversation

simonihmig
Copy link
Member

There were two issues here how the FeatureParser generated imports, that somehow worked in a classic build, but broke in Embroider:

  • the default export of yadda-annotations.js was imported, though that doesn't even exist, it only has named exports. Probably the way ember-cli transpiles ES modules to AMD made this work accidentally!?
  • the import path of the steps file was something like tests/accpetance/steps/foo-steps.js, which is neither an absolute path (there is no tests package) nor a relative. Changed to use relative paths (./steps/foo-steps.js)

Also adds additional test scenarios for Embroider, using their new test infrastructure.

This is based on top of #83, as it would have merge conflicts otherwise, so best review by commit.

@simonihmig
Copy link
Member Author

Tests failing due to embroider-build/embroider#587, but was passing locally when manually installing the embroider dependencies rather through the ember-try helpers.

@simonihmig simonihmig merged commit c4169c1 into master Nov 6, 2020
@simonihmig simonihmig deleted the embroider branch November 6, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants