Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #11

Merged
merged 6 commits into from
Dec 28, 2023
Merged

Cleanup #11

merged 6 commits into from
Dec 28, 2023

Conversation

EECOLOR
Copy link
Member

@EECOLOR EECOLOR commented Oct 25, 2023

Fixes #8

  • Removes deprecated useRoutes which was confusing
  • Removes deprecated useRouteMap which was untyped
  • Partial application of params for reverse routes, this was an interesting convenience, but made it hard to check if the current route is a certain route (because the route was wrapped)
  • Use more practical linking (yarn link) from the example to the library
  • Update dependencies

@EECOLOR EECOLOR requested a review from HJSielcken October 25, 2023 21:47
@socket-security
Copy link

socket-security bot commented Oct 25, 2023

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@kaliber/build 0.0.128...0.0.146 None +19/-75 5.63 MB eecolor
react-spring 9.5.2...9.7.3 None +73/-91 11.4 MB tdfka_rick

- Correct locations for legacy provider
- Enable source maps
Copy link

@HJSielcken HJSielcken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Er zijn nog wat projecten volgens mij die useRouteMap gebruiken. Dus misschien goed om dit nog even in technologie channel te melden .Of is het weghalen van deprecated dingen onderdeel van een major breaking change? Waarschijnlijk we, nu ik het zo uittype

@EECOLOR
Copy link
Member Author

EECOLOR commented Oct 26, 2023

Idd major breaking change :-D

@EECOLOR
Copy link
Member Author

EECOLOR commented Nov 25, 2023

Note to self: we willen een use params die alleen veranderd als de echte params daadwerkelijk veranderen. Dus los van de location changes (die veranderen ook bij een hash change)

@EECOLOR EECOLOR merged commit 7358c56 into master Dec 28, 2023
2 checks passed
@EECOLOR EECOLOR deleted the cleanup branch December 28, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove relative routing
2 participants