Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8679): setting KS only on getMediaConfig counts as anonymous session #68

Merged
merged 1 commit into from
Nov 19, 2018
Merged

fix(FEC-8679): setting KS only on getMediaConfig counts as anonymous session #68

merged 1 commit into from
Nov 19, 2018

Conversation

OrenMe
Copy link
Contributor

@OrenMe OrenMe commented Nov 18, 2018 •
edited
Loading

Description of the Changes

If session is only passed on getMediaConfig and on the provider constructor then the isAnonymous session flag is not set to false.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@OrenMe OrenMe self-assigned this Nov 18, 2018
@yairans yairans changed the title fix(FEC-8679): setting KS only on getMedia Config counts as anonymous session fix(FEC-8679): setting KS only on getMediaConfig counts as anonymous session Nov 19, 2018
@yairans
Copy link
Contributor

yairans commented Nov 19, 2018

@OrenMe generally I think the PR title should describe the issue not the solution. the solution should be in the 'Description of the Changes' section

@OrenMe OrenMe merged commit c843f73 into master Nov 19, 2018
@OrenMe OrenMe deleted the FEC-8679 branch November 19, 2018 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

@dan-ziv dan-ziv Awaiting requested review from dan-ziv

@odedhutzler odedhutzler Awaiting requested review from odedhutzler

Assignees

@OrenMe OrenMe

Labels
Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OrenMe @yairans