fix: remove source tag before config is reset (#740)

* fix: remove source tag before config is reset * update name of method
kaltura · Dec 1, 2023 · e413c40 · e413c40
1 parent 38cbbfb
commit e413c40
Showing 1 changed file with 19 additions and 8 deletions.
diff --git a/src/engines/html5/media-source/adapters/native-adapter.js b/src/engines/html5/media-source/adapters/native-adapter.js
@@ -629,20 +629,14 @@ export default class NativeAdapter extends BaseMediaSourceAdapter {
   destroy(): Promise<*> {
     NativeAdapter._logger.debug('destroy');
     return new Promise((resolve, reject) => {
+      //must be called before super config cause it requires config which is reset in super destroy
+      this._maybeRemoveSourceTag();
       super.destroy().then(
         () => {
           this._drmHandler && this._drmHandler.destroy();
           this._waitingEventTriggered = false;
           this._progressiveSources = [];
           this._loadPromise = null;
-          if (this._config['useSourceTag'] && this._videoElement) {
-            const source = this._videoElement.firstChild;
-            if (source) {
-              Utils.Dom.setAttribute(source, 'src', '');
-              Utils.Dom.removeAttribute(source, 'src');
-              Utils.Dom.removeChild(this._videoElement, source);
-            }
-          }
           this._nativeTextTracksMap = {};
           this._loadPromiseReject = null;
           this._liveEdge = 0;
@@ -663,6 +657,23 @@ export default class NativeAdapter extends BaseMediaSourceAdapter {
     });
   }
 
+  /**
+   * remove source tag
+   * @function _maybeRemoveSourceTag
+   * @returns {void}
+   * @private
+   */
+  _maybeRemoveSourceTag(): void {
+    if (this._config.useSourceTag && this._videoElement) {
+      const source = this._videoElement.firstChild;
+      if (source) {
+        Utils.Dom.setAttribute(source, 'src', '');
+        Utils.Dom.removeAttribute(source, 'src');
+        Utils.Dom.removeChild(this._videoElement, source);
+      }
+    }
+  }
+
   /**
    * Get the parsed tracks
    * @function _getParsedTracks