Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated subscribe param to use tuple path, + tests #2

Merged
merged 2 commits into from
Nov 19, 2019
Merged

Updated subscribe param to use tuple path, + tests #2

merged 2 commits into from
Nov 19, 2019

Conversation

JamesYFC
Copy link
Contributor

No description provided.

kalvinpearce
kalvinpearce requested changes Nov 18, 2019
View reviewed changes
Copy link
Owner

@kalvinpearce kalvinpearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good apart from that import

src/index.ts Outdated Show resolved Hide resolved
@JamesYFC
Copy link
Contributor Author

JamesYFC commented Nov 18, 2019 •
edited
Loading

Also will take a look at overloading possibilities with the path param

@JamesYFC
Copy link
Contributor Author

Also will take a look at overloading possibilities with the path param

nvm, not needed

@JamesYFC
Copy link
Contributor Author

minor cleanups

@kalvinpearce kalvinpearce merged commit 3ef569a into kalvinpearce:master Nov 19, 2019
@kalvinpearce kalvinpearce mentioned this pull request Nov 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalvinpearce kalvinpearce kalvinpearce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamesYFC @kalvinpearce