Support multiple dist configurations and ESM #13
Conversation
ardatan
force-pushed
the
support-multiple-dist
branch
from
101f326 to
227a048
Compare
ardatan
changed the title
| dists?: { | ||
| distDir: string; | ||
| distPath?: string; | ||
| }[] |
There was a problem hiding this comment.
Do we need this or could we maybe have cjs, esm, nodeEsm flags? @ardatan
There was a problem hiding this comment.
what's the story behind dists?
There was a problem hiding this comment.
Having es5 builds for graphql-tools
https://github.com/ardatan/graphql-tools/blob/master/bob.config.js#L9
We have needed that before in MSTeams
There was a problem hiding this comment.
oh, so it's an output from tsc?
There was a problem hiding this comment.
Yes it is actually. https://github.com/ardatan/graphql-tools/blob/master/package.json#L10
Here we run tsc twice in parallel, one is for modern es and the other one is for es5.
There was a problem hiding this comment.
I am not sure this old solution is the best but it worked for MSTeams :D It was a long time ago, we can change it for sure. But that was the reason behind having this dists thing.
There was a problem hiding this comment.
@kamilkisiela @kamilkisiela (for me) add nodeEsm flag to the PR and merge it
There was a problem hiding this comment.
(also for me) update validation rules in bob validate to make sure it’s in sync
| onError | ||
| ); | ||
| shouldEqual( | ||
| pkg.module, | ||
| "dist/index.esm.js", | ||
| `${name}: 'module' should equal 'dist/index.esm.js'`, | ||
| "dist/index.msj", |
There was a problem hiding this comment.
I think this is typo :D
No description provided.