-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ESM and .mts/.cts extensions with jiti loader #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💻 Website PreviewThe latest changes are available as preview in: https://89159711.graphql-config.pages.dev |
11 tasks
dimaMachina
approved these changes
Mar 6, 2023
dimaMachina
reviewed
Mar 6, 2023
dimaMachina
reviewed
Mar 6, 2023
diff --git a/website/algolia-lockfile.json b/website/algolia-lockfile.json
index 802afac..05f4d98 100644
--- a/website/algolia-lockfile.json
+++ b/website/algolia-lockfile.json
@@ -72,7 +72,7 @@
"anchor": "examples"
}
],
- "content": "5d4cca1d7d43f0035cfd8e97b7621806",
+ "content": "3f2010b9337e2dba13844da178eeceac",
"url": "https://www.the-guild.dev/graphql/config/docs/",
"domain": "https://www.the-guild.dev/graphql/config",
"hierarchy": [ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A second approach to adding ESM support. The previous one included using
tsc
and custom caching and this caching bit had a bunch of edge cases that I wasn't aware of in the beginning.I replaced it with
jiti
loader and added more test cases.jiti
is much faster than runningtsc
(similar time to cosmic loader).Related to issues in graphql-code-generator: dotansimha/graphql-code-generator#8509 and dotansimha/graphql-code-generator#8862. More context in this PR: dotansimha/graphql-code-generator#9086.
Type of change
How Has This Been Tested?
Extended existing tests.
Test Environment:
Checklist:
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...