Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage command is broken as core was not released #2340

Closed
4 tasks
velias opened this issue Feb 16, 2023 · 1 comment · Fixed by #2341
Closed
4 tasks

coverage command is broken as core was not released #2340

velias opened this issue Feb 16, 2023 · 1 comment · Fixed by #2341

Comments

@velias
Copy link
Contributor

velias commented Feb 16, 2023

Issue workflow progress

Progress of the issue based on the
Contributor Workflow

  • 1. The issue provides a reproduction available on GitHub, Stackblitz or CodeSandbox

    Make sure to fork this template and run yarn generate in the terminal.

    Please make sure the Codegen and plugins version under package.json matches yours.

  • 2. A failing test has been provided
  • 3. A local solution has been provided
  • 4. A pull request is pending review

Describe the bug

coverage command is broken as core was not released for PR #2184

To Reproduce Steps to reproduce the behavior:

  • run coverage commands, ends with:
/.../node_modules/@graphql-inspector/coverage-command/index.js:115
    logger.Logger.log(`Types covered: ${coverage.stats.numTypes > 0
                                                       ^
TypeError: Cannot read properties of undefined (reading 'numTypes')
    at renderCoverage (/.../node_modules/@graphql-inspector/coverage-command/index.js:115:56)
    at handler (/.../node_modules/@graphql-inspector/coverage-command/index.js:17:9)
    at Object.<anonymous> (/.../node_modules/@graphql-inspector/coverage-command/index.js:83:24)
    at Generator.next (<anonymous>)
    at fulfilled (/.../node_modules/tslib/tslib.js:115:62)

Node.js v18.14.0

Expected behavior

No exception ;-)

Environment:

  • OS:
  • "@graphql-inspector/coverage-command": "^3.4.4",

Additional context

@velias
Copy link
Contributor Author

velias commented Feb 16, 2023

@TuvalSimha there is issue for the problem with not released core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant