-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coverage: provide overall statistics about coverage #2184
Conversation
95912c9
to
f8e98fe
Compare
🦋 Changeset detectedLatest commit: 5c7550f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hey @velias :), Thank you for the suggestion, I find it very useful!
Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add
Changeset
- Add one more unit test
- Make sure the CI checks pass
@TuvalSimha thanks, for sure I'll do my best to provide correct PR. I'm only not sure what do you mean by "Add one more unit test"? Which test, what exactly should be tested? |
@velias Thank you! |
e50bd4f
to
78c563f
Compare
@TuvalSimha OK, I implemented there changes:
Hope this makes PR mergeable |
@TuvalSimha I'm not sure why is |
@velias Hey :) |
@TuvalSimha OK, so does it mean my PR is OK ? |
Hey @velias :) |
@TuvalSimha thanks for merging. |
@TuvalSimha looks like |
Description
Extension of the coverage module to provide overall statistics of the coverage.
Console output contains info like percentage of "Types covered", "Types fully covered" and "Fields fully covered" (fields stat contains also arguments).
JSON output contains more detailed output, like num of types, num of types covered, num of types fully covered, num of fields and num of fields covered (fields numbers contain also arguments).
Motivation is to have simple overall overview of the schema coverage. Also overall statistic number allows to create badge for source code repo of your project.
Fixes #2183
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
./packages/core/__tests__/coverage/coverage.ts
test has been extended to cover statistics../example
has been used to test coverage cli, example json oputput (coverage.json
) is updatedTest Environment:
Checklist:
style guidelines of this project