Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accepts a GitHub Label to mark PR with breaking changes as safe #1711

Merged
merged 3 commits into from
Sep 24, 2020

Conversation

kamilkisiela
Copy link
Owner

Something like this could be done in Actions too

@kamilkisiela kamilkisiela merged commit 6aff065 into master Sep 24, 2020
@kamilkisiela kamilkisiela deleted the feat/app-force-label branch September 24, 2020 09:47
@beamery-tomht
Copy link

Thanks for this. However I can't seem to make it work.

I've added the label
image

The action configuration is very simple:

schema: 'packages/server-plugin-graphql/dist/schema.graphql'

branch: 'master'

diff:
  annotations: true

But the action still fails

image

I've retried several times today in hope it would pull the latest version of graphql-inspector.

@kamilkisiela
Copy link
Owner Author

It's supported by GitHub App, not in Action yet. It will show "Breaking Change" but the GraphQL Inspector check will succeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants