Bug Fix: No deprecation notice for field on fragment in a different document #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…precated field on a fragment in a different document than an operation
…an an operation. Finds deprecated fields using merged document
|
Thanks, I will release it tomorrow. |
|
Did this ever get released? |
|
yes, now as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is currently no deprecated warning raised when using a deprecated field on a fragment, where that fragment is used on an operation in a different document. The culprit appears to be not passing the transformed version of the operation document (includes fragments from other documents) into
findDeprecatedUsages. Included failing test case and fix.Type of change
Checklist: