Feat/rule fs #665
Merged
Feat/rule fs #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilkisiela
approved these changes
Oct 8, 2019
|
|
||
| import {renderChange, Renderer, ConsoleRenderer} from '../render'; | ||
|
|
||
| function hasBreaking(changes: Change[]): boolean { | ||
| return changes.some(c => c.criticality.level === CriticalityLevel.Breaking); | ||
| } | ||
|
|
||
| function resolveRule(name: string): Rule | undefined { | ||
| const filepath = isAbsolute(name) ? name : join(process.cwd(), name); |
There was a problem hiding this comment.
Suggested change
| const filepath = isAbsolute(name) ? name : join(process.cwd(), name); | |
| const filepath = ensureAbsolute(name); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #650
First draft for
ruleargument extension:I will await your feedback and update the implementation if needed.
Afterwards I can update the docs.
Note:
There seems to be an issue with the
@types/react-router-domdependency that caused the ui-package not not to build after first checkout.I fixated the version at 4.3.5 and included the change in the PR (I believe I need it to pass CI), but would be happy to remove that change, if you prefer.