feat: add case_sensitive_ext option for mimetype, theme and icons
#497
Conversation
src/main.rs
Outdated
| @@ -68,6 +68,8 @@ lazy_static! { | |||
|
|
|||
| config_dirs | |||
| }; | |||
|
|
|||
| static ref CONFIG_T: AppConfig = AppConfig::get_config(); | |||
There was a problem hiding this comment.
Having it as a static reference here seems to be the only solution... That's not a problem right?
There was a problem hiding this comment.
Instead of making the config static, I think the less intrusive approach is to just check the config to see if option is enabled and pass the already lowercase version into app_list_for_ext.
ie. inside open_file.rs, change _get_options to take &AppConfig as a parameter
There was a problem hiding this comment.
Well, that works but just for the mimetype part, for theme and icons there is something more to do, but I'll try
|
Here is the new implementation, which involves a lot of extra clones, not sure if that's better than having a static config. Speaking of clones, I was wondering if it would be a good idea to do a major refactor using only one static config (like |
Yeah, the issue is with static, its read-only I believe. |
Currently any file with an uppercase or partially uppercase extension is not recognized by either
mimetype.toml,theme.tomlandicons.toml. With this addition, when the flag is set tofalse, any uppercase/lowercase variant of an extension will be correctly detected. I set it tofalseby default because it just makes sense to me, but we can set it totrueif we want to keep the current behavior by default.