Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifest pkg to use gopkg.in/yaml.v3 #13

Merged
merged 13 commits into from
Feb 8, 2023
Merged

Conversation

colinhoglund
Copy link
Member

@colinhoglund colinhoglund commented Feb 7, 2023

This updates the manifest encoding package to use gopkg.in/yaml.v3 and reduce the number of package dependencies. This also adds more tests/benchmarks.

Please note: The object type definitions are currently incomplete and additional fields can be defined as they are needed by plugins.

@colinhoglund colinhoglund requested a review from dskatz February 7, 2023 22:57
Copy link
Member

@dskatz dskatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose updating the Makefile test target to

go test -cover -benchmem -bench=. -run=$(RUN) $(PKG)

pkg/manifest/encoder.go Outdated Show resolved Hide resolved
@colinhoglund colinhoglund requested a review from dskatz February 8, 2023 16:48
@colinhoglund colinhoglund merged commit 7e53af0 into main Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants