Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Fix default convert router output #3

Merged
merged 2 commits into from
Jun 22, 2022

Conversation

colinhoglund
Copy link
Member

This updates the plugin router to default to using zero conversion plugins and fixes this base case to return the request data rather than an empty string. This also moves the "newline" convert plugin to be just a testing tool and unit tests have bveen updated to validate use case.

@colinhoglund colinhoglund requested a review from dskatz June 22, 2022 18:45
dskatz
dskatz previously approved these changes Jun 22, 2022
Copy link
Member

@dskatz dskatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nit

internal/plugin/router_test.go Outdated Show resolved Hide resolved
Copy link
Member

@dskatz dskatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colinhoglund colinhoglund merged commit 8aa48d7 into main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants