Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove sensitive cli flag #6

Merged
merged 1 commit into from
Jun 23, 2022
Merged

remove sensitive cli flag #6

merged 1 commit into from
Jun 23, 2022

Conversation

colinhoglund
Copy link
Member

remove the --secret flag since it's generally bad practice to pass secrets on the command line.

@colinhoglund colinhoglund requested a review from dskatz June 22, 2022 21:00
dskatz
dskatz approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@dskatz dskatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colinhoglund colinhoglund merged commit 73d3185 into main Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dskatz dskatz dskatz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colinhoglund @dskatz