This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
fix: Proper path parsing. #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catalog, the order was wrong. Plus, using the split characters as part of the field. Fixes kaoto-archive#577
|
SonarCloud Quality Gate failed.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| + previous.getPathSeparator() + previous.convertToType(pathParts.get(i++))); | ||
| } | ||
| Pattern pattern = Pattern.compile("[?&]([^=]+)=([^&\\n]+)", Pattern.CASE_INSENSITIVE); | ||
| Matcher matcher = pattern.matcher(uri); |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data
Codecov Report
@@ Coverage Diff @@
## main #597 +/- ##
============================================
- Coverage 78.79% 78.44% -0.35%
Complexity 132 132
============================================
Files 45 45
Lines 2301 2324 +23
Branches 350 361 +11
============================================
+ Hits 1813 1823 +10
- Misses 326 336 +10
- Partials 162 165 +3
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
igarashitm
approved these changes
Mar 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating camel connectors for the catalog, the order was wrong. Plus, using the split characters as part of the field.
Fixes #577