This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
Add multi flow tests for KB, kamelets and integrations #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delawen
approved these changes
May 10, 2023
|
Good catch! |
Codecov Report
@@ Coverage Diff @@
## main #647 +/- ##
============================================
+ Coverage 77.70% 78.43% +0.73%
Complexity 145 145
============================================
Files 47 47
Lines 2601 2606 +5
Branches 402 405 +3
============================================
+ Hits 2021 2044 +23
+ Misses 399 381 -18
Partials 181 181
|
|
Could be some issue with new lines in windows? Tests fail too much. |
Delawen
suggested changes
May 11, 2023
...aoto/backend/api/service/deployment/generator/camelroute/DeploymentGeneratorServiceTest.java
Outdated
Show resolved
Hide resolved
tplevko
force-pushed
the
add_parseFlows_test
branch
7 times, most recently
from
403fc6f to
51c5f43
Compare
tplevko
changed the title
auto-merge was automatically disabled
May 15, 2023 10:22
Pull request was converted to draft
tplevko
changed the title
|
@Delawen I updated also the KameletBinding and Kamelets DeploymentGeneratorServices. I'm still trying to bypass the windows issues, the |
tplevko
force-pushed
the
add_parseFlows_test
branch
from
51c5f43 to
fd8363d
Compare
tplevko
force-pushed
the
add_parseFlows_test
branch
from
fd8363d to
18559f7
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
tplevko
changed the title
|
This should be ready for review - the |
Delawen
approved these changes
May 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found the flow parsing was adding the '---' at the end of parsed yaml I think it might be cut off.
@Delawen please have a look.