Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

fix: Uncaught exception in getCamelRoute method + increase test coverage #666

Merged
merged 1 commit into from
May 19, 2023

Conversation

mkralik3
Copy link
Contributor

@mkralik3 mkralik3 requested a review from a team May 18, 2023 14:51
@Delawen Delawen requested a review from igarashitm May 18, 2023 14:53
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #666 (7d9c457) into main (5fe92c1) will increase coverage by 0.28%.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##               main     #666      +/-   ##
============================================
+ Coverage     79.28%   79.57%   +0.28%     
  Complexity      148      148              
============================================
  Files            48       48              
  Lines          2660     2663       +3     
  Branches        416      417       +1     
============================================
+ Hits           2109     2119      +10     
+ Misses          369      367       -2     
+ Partials        182      177       -5     
Impacted Files Coverage Δ
...arser/kamelet/KameletBindingStepParserService.java 60.46% <50.00%> (+1.55%) ⬆️
...step/parser/camelroute/CamelRouteDeserializer.java 88.88% <100.00%> (+1.38%) ⬆️

... and 4 files with indirect coverage changes

Copy link
Contributor

@igarashitm igarashitm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one minor comment, otherwise LGTM 👍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mkralik3
Copy link
Contributor Author

Changed to IOException

@mkralik3 mkralik3 requested a review from igarashitm May 19, 2023 12:57
Copy link
Contributor

@igarashitm igarashitm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mkralik3 mkralik3 merged commit d2e2c21 into kaoto-archive:main May 19, 2023
@mkralik3 mkralik3 deleted the fix-662 branch August 3, 2023 10:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Uncaught exception related to parsing in the CamelRouteStepParserService.getCamelRoute method
2 participants