This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
feature(rest-dsl): Adding basic icon to REST DSL steps #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delawen
commented
May 30, 2023
| @@ -70,6 +74,55 @@ private static Step getVerbStep(String verb) { | |||
| return step; | |||
| } | |||
|
|
|||
| @NotNull | |||
There was a problem hiding this comment.
Seriously? You are moved down a couple of lines because of new code and suddenly you are all brand new?
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #681 +/- ##
============================================
+ Coverage 79.01% 79.32% +0.31%
- Complexity 148 149 +1
============================================
Files 48 48
Lines 2678 2685 +7
Branches 423 424 +1
============================================
+ Hits 2116 2130 +14
+ Misses 384 379 -5
+ Partials 178 176 -2
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up till now, it was using the default "rest" string. Now it has a real icon.
