-
Notifications
You must be signed in to change notification settings - Fork 32
Conversation
8dd9f3b
to
18c6485
Compare
Some yaml test resources have been changed because now that we are using other classes the order of the attributes changed. |
api/src/test/resources/io/kaoto/backend/api/resource/camel-conector-example.yaml
Show resolved
Hide resolved
camel-route-support/src/main/java/io/kaoto/backend/model/deployment/camelroute/Integration.java
Show resolved
Hide resolved
cluster/src/main/java/io/kaoto/backend/deployment/ClusterService.java
Outdated
Show resolved
Hide resolved
cluster/src/test/java/io/kaoto/backend/deployment/ClusterServiceTest.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #694 +/- ##
============================================
- Coverage 80.10% 77.60% -2.50%
- Complexity 154 155 +1
============================================
Files 53 53
Lines 2709 2831 +122
Branches 432 466 +34
============================================
+ Hits 2170 2197 +27
- Misses 360 453 +93
- Partials 179 181 +2
|
I know this is a classic, but I swear native build works on my machine :/
|
First difference which jumps to me is that you are not using the same version of Graalvm: https://github.com/KaotoIO/kaoto-backend/blob/a8c5908c0f3adc74ddbab67299fac55f1bdf5413/.github/workflows/analysis.yml#L62
native build and native tests? |
Yes, I am trying with this other version of graalvm
Yes, sure. Same command
|
Same version locally it works. Trying to update graalvm here instead... just in case :/ |
57dfc72
to
af275f1
Compare
kamelet-support/src/main/java/io/kaoto/backend/KamelPopulator.java
Outdated
Show resolved
Hide resolved
af275f1
to
d2aa9de
Compare
This was no longer relevant as we are using Camel CRD classes now, which don't contain Kaoto related properties. Plus the frontend shouldn't care about it.
🤞 🤞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- there are a lot of new lines reported as not covered by tests in KameletRepresenter
api/src/test/resources/io/kaoto/backend/api/resource/camel-conector-example.yaml
Show resolved
Hide resolved
api/src/test/resources/io/kaoto/backend/api/resource/integration.yaml
Outdated
Show resolved
Hide resolved
...ckend/api/service/deployment/generator/camelroute/IntegrationDeploymentGeneratorService.java
Show resolved
Hide resolved
...oute-support/src/main/java/io/kaoto/backend/model/deployment/camelroute/IntegrationSpec.java
Show resolved
Hide resolved
...oute-support/src/main/java/io/kaoto/backend/model/deployment/camelroute/IntegrationSpec.java
Show resolved
Hide resolved
...oute-support/src/main/java/io/kaoto/backend/model/deployment/camelroute/IntegrationSpec.java
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
First iteration to get Camel K CRD in place to reuse as much as possible from Camel model when parsing back and forth.
The idea is to use for parsing and writing the yaml files the official classes that Camel K uses, so we go along with changes and updates.