Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

test: Extend and refactor StepResourceTest #812

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

mkralik3
Copy link
Contributor

To be able to use all tests in native mode

// native tests should failed due to #811

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #812 (b89bcec) into main (9ec1637) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #812   +/-   ##
=========================================
  Coverage     69.96%   69.96%           
  Complexity      199      199           
=========================================
  Files            69       69           
  Lines          3283     3283           
  Branches        555      555           
=========================================
  Hits           2297     2297           
+ Misses          772      771    -1     
- Partials        214      215    +1     

see 2 files with indirect coverage changes

@mkralik3
Copy link
Contributor Author

Hm, weird that it passed in the workflows but it is failing in my local machine due to #811 🤔

The Number of steps that were returned by StepResource API '1121' is different as it was expected '1122'.

@mkralik3
Copy link
Contributor Author

mkralik3 commented Jul 28, 2023

Hm, weird that it passed in the workflows but it is failing in my local machine due to #811 thinking

The Number of steps that were returned by StepResource API '1121' is different as it was expected '1122'.

It looks that workflows use dev profile instead of prod. I don't know why since, by default, prod profile should be used in native testing ( https://quarkus.io/guides/building-native-image#profiles ) , so I have explicitly specified in application.yaml that prod profile should be used during native testing. .. After that, (and before rebase with main with #811 ) , the native test failed as expected.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mkralik3 mkralik3 marked this pull request as ready for review August 3, 2023 08:53
@mkralik3 mkralik3 requested a review from a team August 3, 2023 08:53
@Delawen Delawen merged commit 656ab1f into kaoto-archive:main Aug 3, 2023
@mkralik3 mkralik3 deleted the step_resource branch August 3, 2023 10:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants