This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
[1-3] fix(viz): Avoid showing the MiniCatalog popup when there's no step nor branches available #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ranches available At this moment, trying to append an additional step after a step that has a custom extension, causes to display the MiniCatalog with both tabs disabled and showing the Add branch button enabled. This is problematic because for those steps, a special configuration is required and its provided via its extension, hence disabling the branch tab from the MiniCatalog. This commit disables the plus icon to avoid displaying a non interactive popup to the user and providing a tooltip instead explaining what to do in order to configure the step. This commit also target small improvements in related tests, like changing the api signature of one of the services to only receive a step instead of a whole node. fixes #1473
Codecov Report
@@ Coverage Diff @@
## main #1503 +/- ##
==========================================
+ Coverage 55.24% 56.30% +1.06%
==========================================
Files 59 63 +4
Lines 1975 2014 +39
Branches 462 462
==========================================
+ Hits 1091 1134 +43
+ Misses 838 834 -4
Partials 46 46
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kahboom
previously approved these changes
Mar 17, 2023
In case that the layout from ReactFlow change, we need to update the handlers and Prepend/Append buttons as well. Currently this is being handled with a template conditional to determine which CSS class should be applied. This commit aims to simplify that by leveraging the concept of specificity by relying on a class applied to the parent element and the children reacting to that, this way we rely on the browser to do the changes instead of JS. This is a spinoff of https://github.com/KaotoIO/kaoto-ui/pull/1485/files#r1138269126
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This pull request is the first of three pull requests:
These pull requests are built on top of #1485
Description
Based on #1473, when a step has an associated custom extension available and there's no next step available to pick, the MiniCatalog was still displayed to the user, with both tabs disabled but with a visible
Add Branchbutton completely interactive.Changes
This commit disables the plus icon to avoid displaying a non-interactive popup to the user and provides a tooltip instead explaining what to do in order to configure the step.
This commit also targets small improvements in related tests, like changing the API signature of one of the services to only receive a step instead of a whole node.
fixes part of #1473