Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

chore: Hide Config tab if no properties exist #1658

Merged
merged 1 commit into from
Apr 18, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/components/VisualizationStepViews.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@ const VisualizationStepViews = ({
};

useEffect(() => {
setActiveTabKey(configTabIndex);
setActiveTabKey(()=>
step.parameters?.length ? configTabIndex : detailsTabIndex);
let tempSchemaObject: { [label: string]: { type: string; value?: any; description?: string } } =
{};

Expand Down Expand Up @@ -187,7 +188,7 @@ const VisualizationStepViews = ({
})}

{/** If the step does not have an overriding Config view, provide the default one */}
{!hasConfigView && (
{step.parameters?.length! > 0 && !hasConfigView && (
<Tab
eventKey={configTabIndex}
title={<TabTitleText>Config</TabTitleText>}
Expand Down