Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

fix (GitHub_Actions):Fixing issue related to warning Unexpected input(s) 'username' for Generate Docker image #1665

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

MohammadiIram
Copy link
Contributor

Which issue(s) this PR fixes #1539

@MohammadiIram MohammadiIram requested a review from a team April 17, 2023 10:50
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
15.1% 15.1% Duplication

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #1665 (9d190bc) into main (602f943) will increase coverage by 4.67%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1665      +/-   ##
==========================================
+ Coverage   61.05%   65.72%   +4.67%     
==========================================
  Files          70       71       +1     
  Lines        2054     2048       -6     
  Branches      470      467       -3     
==========================================
+ Hits         1254     1346      +92     
+ Misses        756      660      -96     
+ Partials       44       42       -2     

see 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kahboom
Copy link
Contributor

kahboom commented Apr 17, 2023

thanks for this @MohammadiIram , it would be good to get a quick review from @apupier though he is at the F2F this week

@kahboom kahboom requested a review from apupier April 17, 2023 12:15
@MohammadiIram
Copy link
Contributor Author

thanks for this @MohammadiIram , it would be good to get a quick review from @apupier though he is at the F2F this week

Yeah, Sure.

@lordrip
Copy link
Collaborator

lordrip commented Apr 26, 2023

Compared the input list against the docs and there's no username property.

@lordrip
Copy link
Collaborator

lordrip commented Apr 26, 2023

Also, the DeepScan issue is failing because of an unused import which is not related to this pull request.

@lordrip lordrip merged commit d4fb0d8 into kaoto-archive:main Apr 26, 2023
@lordrip
Copy link
Collaborator

lordrip commented Apr 26, 2023

Almost forgot, thanks @MohammadiIram for taking care of this 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix issue related to warning Unexpected input(s) 'username' for Generate Docker image GitHub Actions
3 participants