This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
feat(multiple-flows): Enable experimental support for multiple flows #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to: #801
In the existing useIntegrationJSONStore, there are individual methods to handle the different interaction between the flows' steps. In the new useFlowsStore the attempt is to have a single method that handle the same interactions but using a command-like approach of 'append', 'insert', 'replace'. This API might be subject to change in the future as more functionality gets ported from single flow to multiple flows Relates to: #801
In order to support multiple flows in the UI, we need to switch our model from a single flow to an array of flows. In practical terms, there are at least two alternatives: 1. Refactor existing `IIntegrationJSONStore` to support multiple flows 2. Move from `IIntegrationJSONStore` to another store that supports multiple flows. In this commit, the latter was chosen, and for that purpose, the `useFlowsStore` was created. In this commit, also an additional setting was added to switch between single and multiple flows during runtime, to avoid any potential big-bang effect while developing this feature. Relates to: #801
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #1749 +/- ##
==========================================
- Coverage 66.43% 66.35% -0.08%
==========================================
Files 74 74
Lines 2121 2158 +37
Branches 472 482 +10
==========================================
+ Hits 1409 1432 +23
- Misses 668 682 +14
Partials 44 44
|
igarashitm
approved these changes
May 8, 2023
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In order to support multiple flows in the UI, we need to switch our data model from a single flow to an array of flows.
In practical terms, there are at least two alternatives:
IIntegrationJSONStoreto support multiple flowsIIntegrationJSONStoreto another store that supports multiple flows and ports the existing functionality.Changes
In this pull request, the latter was chosen, and for that purpose, the
useFlowsStorewas created. It also includes an additional setting to switch between single and multiple flows during runtime, to avoid any potential big-bang effect while developing this feature.Notes
Not all the functionality existing in Single Flow Mode is ported to the Multiple Flows Mode. Subsequent pull requests will add more functionality gradually.
Limitations
Screenshots
New setting: Enable experimental support for multiple flows
Demo: Multiple flows
Related discussion: #1750
Relates to: #801
Related backend pull request: kaoto-archive/kaoto-backend#638