This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
Feat/add new flow #1870
Merged
Feat/add new flow #1870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to make the toolbar buttons more user friendly, we're adding text to each of them, to convey their purpose easily.
* Leverage testMatch property to scan for tests * Add babel-jest to load ESM Javascript from node-modules (@patternfly/react-core/next) * Adjust coverage collection to ignore stubs, tests and index files * Map @patternfly/react-core/next to @patternfly/react-core/next/dist/cjs * Remove ignore from .prettierignore
Currently, there is no mechanism to create a new flow in the
canvas despite now the backend supporting such a feature.
This commit adds the capability to create a new flow directly
from the Toolbar.
Changes:
* Remove Integration name from the Toolbar
* Add a new dropdown to select the new flow dsl
* In case of the dsl of the existing flows is
the same as the new one, a new flow is created
* On the contrary, a modal is displayed to warn the
user that the current flows will be lost
relates to: #801
11 tasks
Codecov Report
@@ Coverage Diff @@
## main #1870 +/- ##
==========================================
- Coverage 65.64% 57.93% -7.72%
==========================================
Files 73 70 -3
Lines 2131 2439 +308
Branches 526 566 +40
==========================================
+ Hits 1399 1413 +14
- Misses 688 976 +288
- Partials 44 50 +6
|
The underlying functionality that these tests covers, has changed in favor of directly selecting the flow type whenever we create a new route so they no longer applies. relates to: #801
From the docs: https://docs.codecov.com/docs/commit-status "removed_code_behavior: adjust_base": consists in adjusting the BASE coverage by recalculating it, and then comparing it to the unchanged HEAD. The adjustment is to remove misses, hits and partials from lines that were removed in the diff from BASE (as if all removals were made already in BASE) and re-calculate coverage (coverage = hits / (hits + misses + partials)). This behavior is skipped if target coverage is defined. Example: The project status check (if status threshold: is default/not set or automatic) will pass because adjusted base coverage = 9 starting lines in base MINUS 3 removed lines in the head of the PR = 6 covered lines in adjust_base / 10 starting lines in base MINUS 3 removed lines in the head of the PR = 7 covered lines in adjust_base Adjusted base coverage % = 85.7% Therefore project coverage has increased to 87.5% (7/8 covered lines) from adjusted_base of 85.7%, an increase of 1.8%.
|
Kudos, SonarCloud Quality Gate passed!
|
igarashitm
approved these changes
May 30, 2023
|
sonarcloud claims some "code smells", maybe that |
|
Thanks @igarashitm , I didn't notice that there were code smells as the step was green 😮💨 , I'll fix those in my upcoming pull request 👌 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, there is no mechanism to create a new flow in the canvas despite now the backend supporting such a feature.
This pull request adds the capability to create a new flow directly from the Toolbar.
Changes:
Integration namecomponent from theToolbarDemo
Create a new flow
Create.new.routes.mp4
Changing flow type
Warning.before.changing.DSL.mp4
relates to: #801