This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
fix(viz): Avoid rerendering of VisualizationStepViews #1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the Visualization component is consuming several properties from the VisualizationStore, and this makes it more susceptible to store changes, causing rerendering of the VisualizationStepViews component, and this in turn generates a flickering in the step extensions. The fix is to add the 'shallow' function to the 'useVisualizationStore()' in order to only react to changes in the actual value of said properties. Relates to: #801
11 tasks
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #1901 +/- ##
==========================================
- Coverage 58.88% 58.80% -0.09%
==========================================
Files 72 72
Lines 2539 2534 -5
Branches 574 574
==========================================
- Hits 1495 1490 -5
Misses 993 993
Partials 51 51
|
igarashitm
approved these changes
Jun 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, the
Visualizationcomponent is consuming several properties from theVisualizationStore, and this makes it more susceptible to store changes, causing rerendering of theVisualizationStepViewscomponent, and this, in turn, generates a flickering in the step extensions.Changes
The fix is to add the 'shallow' function to the 'useVisualizationStore()' in order to only react to changes in the actual value of said properties.
Relates to: #801