Add basic set of multiflow tests #1921
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1921 +/- ##
=======================================
Coverage 59.89% 59.89%
=======================================
Files 76 76
Lines 2516 2516
Branches 565 565
=======================================
Hits 1507 1507
Misses 962 962
Partials 47 47
|
tplevko
force-pushed
the
multiflow_tests
branch
3 times, most recently
from
4a72432 to
1af67b9
Compare
| uri: timer:test | ||
| steps: | ||
| - to: | ||
| uri: log:log2 |
There was a problem hiding this comment.
This integration type will be slightly different from what it is now. Later on, multiple routes from the Integration type will be handled inside of the flows array but this is in the works at the backend.
Can I suggest you another fixture in the meantime? This is a multiple Camel route fixture.
- from:
uri: cron:cron
parameters:
schedule: '1000'
steps:
- set-body:
simple: body
- to:
uri: log:log1
- from:
uri: timer:test
steps:
- to:
uri: log:log2There was a problem hiding this comment.
sure, thanks for letting me know - will convert this to the flows once it's in the backend. Also the second fixture - I'll extend the tests and add there also camelRoute type tests, so the covered area represents all the possible route options.
| .then((element) => { | ||
| cy.wrap(element).click(); | ||
| }); | ||
| cy.get('.pf-c-modal-box__footer').children('.pf-c-button.pf-m-primary').click(); |
There was a problem hiding this comment.
Would it be convenient to have a better handler for the Accept button? I can add it 😃
There was a problem hiding this comment.
no prob - I should have added data-test-id and will change that. Really looks "subotimal" :)
| @@ -64,7 +64,7 @@ Cypress.Commands.add('deleteStep', (step, stepIndex) => { | |||
| const previousStepsCount = elem.length; | |||
|
|
|||
| /** Delete the given step */ | |||
| cy.get(`[data-testid="viz-step-${step}"]`).eq(stepIndex).trigger('mouseover').children('[data-testid="configurationTab__deleteBtn"]').click({ force: true }); | |||
| cy.get(`[data-testid="viz-step-${step}"]`,{withinSubject:null}).eq(stepIndex).trigger('mouseover').children('[data-testid="configurationTab__deleteBtn"]').click({ force: true }); | |||
There was a problem hiding this comment.
Is this {withinSubject: null} ok or would be better to have a dedicated handler from the UI side?
There was a problem hiding this comment.
found this is probably redundant - removed, thanks for noticing this
tplevko
force-pushed
the
multiflow_tests
branch
3 times, most recently
from
1015617 to
0b6cc4f
Compare
| @@ -80,6 +80,7 @@ Cypress.Commands.add('openStepConfigurationTab', (step, EIP, stepIndex) => { | |||
| if (!EIP) { | |||
| cy.get('[data-testid="kaoto-right-drawer"]').should('be.visible'); | |||
| } | |||
| cy.waitVisualizationUpdate(); | |||
There was a problem hiding this comment.
This should be workarround for #1855
There was a problem hiding this comment.
Awesome, I'll link your message on that issue, right now is just saying that the issue got mentioned on this pull request and I think it will come in handy to ensure that the bug was fixed.
tplevko
force-pushed
the
multiflow_tests
branch
2 times, most recently
from
5b1618f to
61e9685
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Add basic set of multiflow tests - both for canvas and editor.
The basic tests include:
Editor - based:
Canvas - based: