This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
fix(code-editor): Update schema upon syncing the code #1971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the validation schema is set whenever the code editor is mounted and in case of the user updates the DSL then the schema no longer applies, showing a yellow squiggle. The fix is to listen to the dsl property and set the appropriate schema when changes. fixes: #1166
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #1971 +/- ##
==========================================
+ Coverage 60.72% 61.05% +0.33%
==========================================
Files 78 78
Lines 2546 2550 +4
Branches 576 576
==========================================
+ Hits 1546 1557 +11
+ Misses 956 948 -8
- Partials 44 45 +1
|
igarashitm
approved these changes
Jun 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, the validation schema is set whenever the code editor is mounted and in case of the user updates the DSL then the schema no longer applies, showing a yellow squiggle.
The fix is to listen to the dsl property and set the appropriate schema when changes.
Before
Screencast.from.2023-06-15.21-53-06.webm
After
Screencast.from.2023-06-15.21-49-38.webm
fixes: #1166