Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

fix(beans): Restore default padding from the table row #2025

Merged
merged 1 commit into from
Jun 23, 2023
Merged

fix(beans): Restore default padding from the table row #2025

merged 1 commit into from
Jun 23, 2023

Conversation

lordrip
Copy link
Collaborator

@lordrip lordrip commented Jun 22, 2023

Before

image

After

image

fixes: #2003

@lordrip lordrip marked this pull request as ready for review June 22, 2023 15:17
@lordrip lordrip requested a review from a team June 22, 2023 15:17
@@ -81,7 +81,6 @@ export function PropertyRow({
<TreeRowWrapper
key={`${propertyName}-${path.join('-')}`}
row={{ props: treeRow!.props }}
className="propertyRow"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #2025 (56b2fb9) into main (cb2d861) will increase coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2025      +/-   ##
==========================================
+ Coverage   64.87%   65.05%   +0.17%     
==========================================
  Files          87       87              
  Lines        2824     2847      +23     
  Branches      650      656       +6     
==========================================
+ Hits         1832     1852      +20     
- Misses        946      948       +2     
- Partials       46       47       +1     
Impacted Files Coverage Δ
src/components/metadata/PropertyPlaceholderRow.tsx 87.50% <ø> (ø)
src/components/metadata/PropertyRow.tsx 88.63% <ø> (ø)

... and 7 files with indirect coverage changes

@igarashitm igarashitm merged commit 2247c43 into kaoto-archive:main Jun 23, 2023
@lordrip lordrip deleted the fix/restore-default-table-padding branch July 10, 2023 11:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top of the editable field to add properties in beans configuration is cropped
2 participants