This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
fix(vscode): Missing backend version in vscode #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, there's a race condition caused between 'KogitoEditorIntegrationProvider.tsx' and the 'KaotoToolbar.tsx' as the latter holds an outdated reference to the settings object, causing to the backend version be removed. The fix is to use the correct API for the 'setSettings()' hook in which we only pass the property to be updated and nothing more. fixes: KaotoIO/vscode-kaoto#287
lordrip
commented
Jun 23, 2023
| @@ -86,9 +86,8 @@ export const KaotoToolbar = ({ | |||
| // fetch default namespace from the API, | |||
| useEffect(() => { | |||
| fetchDefaultNamespace().then((data) => { | |||
| const newSettings = settings; | |||
There was a problem hiding this comment.
This was the main issue, in this hook, the settings object is outdated.
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #2035 +/- ##
==========================================
- Coverage 65.07% 65.05% -0.03%
==========================================
Files 87 87
Lines 2849 2847 -2
Branches 656 656
==========================================
- Hits 1854 1852 -2
Misses 948 948
Partials 47 47
|
|
works in VS code:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, there's a race condition caused between the
KogitoEditorIntegrationProvider.tsxand theKaotoToolbar.tsxas the latter holds an outdated reference to the settings object, causing the backend version to be removed.Changes
The fix is to use the correct API for the 'setSettings()' hook in which we only pass the property to be updated and nothing more.
Also, there's an icon property set in the
settingsStorewhich causes the comparison to be slower than needed, as it holds the base64 representation of an image.fixes: KaotoIO/vscode-kaoto#287