Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

fix(sonar): Fix sonar issues #2038

Merged
merged 5 commits into from
Jun 26, 2023
Merged

fix(sonar): Fix sonar issues #2038

merged 5 commits into from
Jun 26, 2023

Conversation

lordrip
Copy link
Collaborator

@lordrip lordrip commented Jun 26, 2023

Context

For a few days, sonar has been tagging the commits as failed since there are issues that need addressing.

Sonar summary

image

Sonar dashboard

image

Changes

This pull request focus on the initial 3 categories since:

  • Have a higher priority
  • Don't impact the source code

@lordrip lordrip requested a review from a team June 26, 2023 09:54
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #2038 (941f255) into main (fbd37c5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2038   +/-   ##
=======================================
  Coverage   65.05%   65.05%           
=======================================
  Files          87       87           
  Lines        2847     2847           
  Branches      656      656           
=======================================
  Hits         1852     1852           
  Misses        948      948           
  Partials       47       47           

igarashitm
igarashitm previously approved these changes Jun 26, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lordrip lordrip merged commit 66c9a73 into kaoto-archive:main Jun 26, 2023
@lordrip lordrip deleted the fix/sonar-issues branch June 26, 2023 12:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants