Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

fix(beans): Remove onBlue saving and add save/cancel buttons for more… #2212

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

igarashitm
Copy link
Contributor

… predictable behavior

Fixes: #2168
Fixes: #2169

@igarashitm igarashitm requested a review from a team July 28, 2023 19:32
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #2212 (d6d0392) into main (9f33d49) will increase coverage by 0.37%.
The diff coverage is 87.17%.

@@            Coverage Diff             @@
##             main    #2212      +/-   ##
==========================================
+ Coverage   71.72%   72.09%   +0.37%     
==========================================
  Files          91       90       -1     
  Lines        3034     3042       +8     
  Branches      706      716      +10     
==========================================
+ Hits         2176     2193      +17     
+ Misses        819      809      -10     
- Partials       39       40       +1     
Files Changed Coverage Δ
...-ui/src/components/metadata/ToopmostArrayTable.tsx 100.00% <ø> (+3.22%) ⬆️
...oto-ui/src/components/metadata/PropertiesField.tsx 90.16% <81.81%> (ø)
...s/kaoto-ui/src/components/metadata/PropertyRow.tsx 91.04% <86.04%> (+2.40%) ⬆️
...ui/src/components/metadata/MetadataEditorModal.tsx 96.15% <91.66%> (+9.19%) ⬆️

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
25.9% 25.9% Duplication

@lordrip lordrip merged commit cc3d0e9 into kaoto-archive:main Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants