This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Fix various a11y issues with focus and aria labels (develop) #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When opening the drop down menu, the focus is set on the entire drop down menu. This prevents keyboard navigation through each of the items in the drop down menu.
- When a modal is opened, set the focus on the close button.
- Job Access With Speech (JAWS) does not read the tooltip content when focus is placed on the input fields in the modals. Other screenreaders, VoiceOver on MacOS, do read the tooltip text. To ensure all screenreaders read the tooltip content, put the tooltip text on each of the input fields.
- Add a new keyboard combination for Windows. On Windows, Control + Shift + Q will quit the browser, so replace Control with Alt.
|
I had to force push because one of the commit messages had stale information that was not reflected in the code changes. The code changes remains the same, only the commit message |
k8vance88
approved these changes
Sep 20, 2019
kinueng
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit messages for details. In a nutshell
Fix focus when using dropdown menus and modals.
Opening Modal from OverflowMenu, focus is not placed on the Modal's selectorPrimaryFocus carbon-design-system/carbon#4036
Improve the text announced by screen readers in the modal input fields.
Add support for Windows users for tabbing out of the Ace Editor (aka JSON Editor)